-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
deps: update nghttp3 to 1.13.1 #60046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
afed68e to
19e6e9e
Compare
19e6e9e to
2cc4e01
Compare
888ad6e to
834fcec
Compare
|
There's a build failure to address |
834fcec to
8967780
Compare
8967780 to
31b9dce
Compare
31b9dce to
7486d13
Compare
a12967c to
7329e0c
Compare
7329e0c to
8dc06ae
Compare
8dc06ae to
4fbae2d
Compare
4fbae2d to
23df677
Compare
|
I don't know if 44798d1 is the right way (I copied the documented default values), but build is fixed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60046 +/- ##
==========================================
- Coverage 88.52% 88.52% -0.01%
==========================================
Files 703 703
Lines 208539 208589 +50
Branches 40220 40222 +2
==========================================
+ Hits 184611 184645 +34
- Misses 15947 15961 +14
- Partials 7981 7983 +2
🚀 New features to boost your workflow:
|
|
@nodejs/quic |
aduh95
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land as is before the bot force push the local changes away, we can always follow up if the default values were not the best fitted
|
Landed in 15bdf38 |
This is an automated update of nghttp3 to 1.13.1.