Skip to content

benchmark: allow boolean option values in createBenchmark #60129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SeokhunEom wants to merge 2 commits into from
Closed

benchmark: allow boolean option values in createBenchmark #60129

SeokhunEom wants to merge 2 commits into from
+7 −9

Conversation

@SeokhunEom
Copy link
Contributor

@SeokhunEom SeokhunEom commented Oct 6, 2025 •
edited
Loading

  1. Change createBenchmark to also accept booleans options.
  2. Use boolean values for randomUUID benchmark and deprecate benchmark instead of 0/1.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 6, 2025

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. crypto Issues and PRs related to the crypto subsystem. performance Issues and PRs related to the performance of Node.js. util Issues and PRs related to the built-in util module. labels Oct 6, 2025
@SeokhunEom SeokhunEom force-pushed the benchmark-boolean-option branch 4 times, most recently from 5e643fc to bea0f69 Compare October 6, 2025 16:58
@SeokhunEom SeokhunEom force-pushed the benchmark-boolean-option branch from bea0f69 to ad0c9ac Compare October 7, 2025 01:15
aduh95
aduh95 reviewed Nov 8, 2025
View reviewed changes
@SeokhunEom
benchmark: allow boolean option values
696f8f0 
Change createBenchmark to also accept booleans.
@SeokhunEom
benchmark: use boolean options in benchmark tests
095165a 
Use boolean values for randomUUID benchmark and
deprecate benchmark instead of 0/1.
@SeokhunEom SeokhunEom force-pushed the benchmark-boolean-option branch from ad0c9ac to 095165a Compare December 14, 2025 11:54
@aduh95
Copy link
Contributor

aduh95 commented Dec 15, 2025

Benchmark CI: https://github.com/aduh95/node/actions/runs/20227758200

@SeokhunEom
Copy link
Contributor Author

SeokhunEom commented Dec 25, 2025

Hello @RafaelGSS,
Can you help me to merge this PR? I think I need to run CI.
Thank you take care.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Dec 25, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 25, 2025

Landed in 13073a9...42d0e13

nodejs-github-bot pushed a commit that referenced this pull request Dec 25, 2025
@SeokhunEom @nodejs-github-bot
benchmark: allow boolean option values
7b7004a 
Change createBenchmark to also accept booleans.

PR-URL: #60129
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
nodejs-github-bot pushed a commit that referenced this pull request Dec 25, 2025
@SeokhunEom @nodejs-github-bot
benchmark: use boolean options in benchmark tests
42d0e13 
Use boolean values for randomUUID benchmark and
deprecate benchmark instead of 0/1.

PR-URL: #60129
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments

@benjamingr benjamingr benjamingr approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. crypto Issues and PRs related to the crypto subsystem. performance Issues and PRs related to the performance of Node.js. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SeokhunEom @nodejs-github-bot @aduh95 @benjamingr @RafaelGSS @gurgunday