Skip to content

Possible Fix: Issue #60263 (Crypto cant sign/verify prehashed inputs) #60458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Possible Fix: Issue #60263 (Crypto cant sign/verify prehashed inputs) #60458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions deps/ncrypto/ncrypto.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4298,18 +4298,46 @@ bool EVPMDCtxPointer::copyTo(const EVPMDCtxPointer& other) const {
std::optional<EVP_PKEY_CTX*> EVPMDCtxPointer::signInit(const EVPKeyPointer& key,
const Digest& digest) {
EVP_PKEY_CTX* ctx = nullptr;

if (digest == nullptr) {
// Inicializa sin digest (firma raw, sin hashing interno)
ctx = EVP_PKEY_CTX_new(key.get(), nullptr);
if (!ctx) return std::nullopt;
if (EVP_PKEY_sign_init(ctx) <= 0) {
EVP_PKEY_CTX_free(ctx);
return std::nullopt;
}
ctx_.reset(ctx);
return ctx;
}

if (!EVP_DigestSignInit(ctx_.get(), &ctx, digest, nullptr, key.get())) {
return std::nullopt;
}

return ctx;
}

std::optional<EVP_PKEY_CTX*> EVPMDCtxPointer::verifyInit(
const EVPKeyPointer& key, const Digest& digest) {
EVP_PKEY_CTX* ctx = nullptr;

if (digest == nullptr) {
// Inicializa sin digest (verificación raw, sin hashing interno)
ctx = EVP_PKEY_CTX_new(key.get(), nullptr);
if (!ctx) return std::nullopt;
if (EVP_PKEY_verify_init(ctx) <= 0) {
EVP_PKEY_CTX_free(ctx);
return std::nullopt;
}
ctx_.reset(ctx);
return ctx;
}

if (!EVP_DigestVerifyInit(ctx_.get(), &ctx, digest, nullptr, key.get())) {
return std::nullopt;
}

return ctx;
}

Expand Down