Skip to content

tls: move _tls_* to end-of-life #60658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjohansebas wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −55
Open

tls: move _tls_* to end-of-life #60658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion doc/api/deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4179,6 +4179,9 @@ npx codemod@latest @nodejs/repl-builtin-modules

<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/60658
description: End-of-Life.
- version:
- v24.2.0
- v22.17.0
Expand All @@ -4187,7 +4190,7 @@ changes:
description: Runtime deprecation.
-->

Type: Runtime
Type: End-of-Life

The `node:_tls_common` and `node:_tls_wrap` modules are deprecated as they should be considered
an internal nodejs implementation rather than a public facing API, use `node:tls` instead.
Expand Down
10 changes: 0 additions & 10 deletions lib/_tls_common.js
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions lib/_tls_wrap.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion lib/eslint.config_partial.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,6 @@ export default [
{
files: [
'lib/_http_*.js',
'lib/_tls_*.js',
'lib/http.js',
'lib/http2.js',
'lib/internal/http.js',
Expand Down
2 changes: 0 additions & 2 deletions lib/internal/main/mksnapshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ const supportedModules = new SafeSet(new SafeArrayIterator([
'_stream_transform',
'_stream_wrap',
'_stream_writable',
// '_tls_common',
// '_tls_wrap',
'assert',
'assert/strict',
// 'async_hooks',
Expand Down
4 changes: 2 additions & 2 deletions src/node_builtins.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,8 @@ BuiltinLoader::BuiltinCategories BuiltinLoader::GetBuiltinCategories() const {
#endif // !NODE_USE_V8_PLATFORM || !defined(NODE_HAVE_I18N_SUPPORT)

#if !HAVE_OPENSSL
"crypto", "crypto/promises", "https", "http2", "tls", "_tls_common",
"_tls_wrap", "internal/tls/parse-cert-string", "internal/tls/common",
"crypto", "crypto/promises", "https", "http2", "tls",
"internal/tls/parse-cert-string", "internal/tls/common",
"internal/tls/wrap", "internal/tls/secure-context",
"internal/http2/core", "internal/http2/compat",
"internal/streams/lazy_transform",
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-internal-module-require.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ const expectedPublicModules = new Set([
'_stream_transform',
'_stream_wrap',
'_stream_writable',
'_tls_common',
'_tls_wrap',
'assert',
'async_hooks',
'buffer',
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-process-get-builtin.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ if (!isMainThread) {
if (!hasCrypto) {
publicBuiltins.delete('crypto');
publicBuiltins.delete('tls');
publicBuiltins.delete('_tls_common');
publicBuiltins.delete('_tls_wrap');
publicBuiltins.delete('http2');
publicBuiltins.delete('https');
publicBuiltins.delete('inspector');
Expand Down
11 changes: 0 additions & 11 deletions test/parallel/test-warn-tls-common-deprecation.js
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions test/parallel/test-warn-tls-wrap-deprecation.js
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@
"_stream_transform": ["./lib/_stream_transform.js"],
"_stream_wrap": ["./lib/_stream_wrap.js"],
"_stream_writable": ["./lib/_stream_writable.js"],
"_tls_common": ["./lib/_tls_common.js"],
"_tls_wrap": ["./lib/_tls_wrap.js"],
"assert": ["./lib/assert.js"],
"assert/strict": ["./lib/assert/strict.js"],
"async_hooks": ["./lib/async_hooks.js"],
Expand Down
Loading