doc: warn about short GCM tags visibly #61082
Merged
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
crypto
Collaborator
|
Review requested:
|
panva
approved these changes
Dec 16, 2025
tniessen
added
the
author ready
aduh95
reviewed
Dec 16, 2025
tniessen
added
the
commit-queue-squash
aduh95
approved these changes
Dec 16, 2025
aduh95
added
the
commit-queue
cjihrig
approved these changes
Dec 16, 2025
|
Would it be a good idea also to link to that warning here? |
As was pointed out by Félix Charette (@Sideni), the existing runtime deprecation warning may not provide enough visibility of the underlying issue. This commit adds a (not so pretty) warning to the documentation of the relevant API function `setAuthTag()`. The warning will be removed when `DEP0182` will be moved to End-of-Life status, presumably with the next major release. Refs: nodejs#52327 Refs: nodejs#17523
tniessen
force-pushed
the
doc-warn-gcm-short-tags
branch
from
4aa3de8 to
3edeaa8
Compare
Member
Author
|
@Sideni I think that's fair -- PTAL. |
lpinca
approved these changes
Dec 16, 2025
BethGriggs
approved these changes
Dec 17, 2025
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in e201759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As was pointed out by Félix Charette (@Sideni), the existing runtime deprecation warning may not provide enough visibility of the underlying issue. This commit adds a (not so pretty) warning to the documentation of the relevant API function
setAuthTag(). The warning will be removed whenDEP0182will be moved to End-of-Life status (#61084), presumably with the next major release.(For some reason,make format-mdforces line 969 to be way too long, not sure what's going on there.)Refs: #52327
Refs: #17523