module: fix sync resolve hooks for require with node: prefixes

[joyeecheung]

Previously, when require()-ing builtins with the node: prefix, the sync resolve hooks were not properly invoked, and load hooks could not override the builtin's format. This fixes the handling and enables redirecting prefixed built-ins to on-disk files and overriding them with other module types via hooks.

Fixes: #60005

[nodejs-github-bot]

Review requested:

• @nodejs/loaders

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (4f24aff) to head (a84209d).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #61088   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         703      703           
  Lines      208546   208590   +44     
  Branches    40217    40228   +11     
=======================================
+ Hits       184634   184675   +41     
+ Misses      15926    15915   -11     
- Partials     7986     8000   +14     

Files with missing lines	Coverage Δ
lib/internal/modules/cjs/loader.js	98.11% <100.00%> (+0.13%)	⬆️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ljharb]

i'm confused; i thought the prefix was meant to prevent any kind of user intervention in accessing the core module, with require.extensions OR loaders - does this PR change that?

[joyeecheung]

i thought the prefix was meant to prevent any kind of user intervention in accessing the core module, with require.extensions OR loaders - does this PR change that?

module.register already allows customizations of modules prefixed with node: (as far back as 20)

echo "require('node:tls')" > test.cjs
node --import ./test/fixtures/module-hooks/register-logger-async-hooks.mjs test.cjs

resolve file:///Users/joyee/projects/node/test.cjs from undefined
load file:///Users/joyee/projects/node/test.cjs
resolve node:tls from file:///Users/joyee/projects/node/test.cjs
load node:tls

[ljharb]

wow, ok, that's unfortunate - that was one of the primary justifications for adding the prefix in the first place, the performance and reliability benefit of not being able to intercept it.

[joyeecheung]

Addressed the comments and fixed the linter complaint. PTAL, thanks! @aduh95

[github-actions]

Failed to start CI

   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/20415476248

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70575/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/61088
✔  Done loading data for nodejs/node/pull/61088
----------------------------------- PR info ------------------------------------
Title      module: fix sync resolve hooks for require with node: prefixes (#61088)
Author     Joyee Cheung <joyeec9h3@gmail.com> (@joyeecheung)
Branch     joyeecheung:fix-node-hooks -> nodejs:main
Labels     module, author ready, needs-ci
Commits    2
 - module: fix sync resolve hooks for require with node: prefixes
 - fixup! module: fix sync resolve hooks for require with node: prefixes
Committers 1
 - Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/61088
Fixes: https://github.com/nodejs/node/issues/60005
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61088
Fixes: https://github.com/nodejs/node/issues/60005
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 16 Dec 2025 14:48:51 GMT
   ✔  Approvals: 1
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61088#pullrequestreview-3602021967
   ✘  This PR needs to wait 37 more hours to land (or 0 minutes if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-12-21T22:09:15Z: https://ci.nodejs.org/job/node-test-pull-request/70575/
- Querying data for job/node-test-pull-request/70575/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/20419381566

[nodejs-github-bot]

Landed in 28f468a