-
-
Notifications
You must be signed in to change notification settings - Fork 34.2k
fix: custom inspect should not throw when called with wrong this #61128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 4 commits into
nodejs:main
from
efekrskl:fix/remove-eventtarget-custom-inspect-branding
Dec 22, 2025
Merged
fix: custom inspect should not throw when called with wrong this #61128
nodejs-github-bot
merged 4 commits into
nodejs:main
from
efekrskl:fix/remove-eventtarget-custom-inspect-branding
Dec 22, 2025
+19
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0530cf0 to
830ace5
Compare
BridgeAR
reviewed
Dec 20, 2025
test/parallel/test-eventtarget-custom-inspect-does-not-throw.js
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61128 +/- ##
=======================================
Coverage 88.53% 88.54%
=======================================
Files 703 703
Lines 208546 208543 -3
Branches 40217 40223 +6
=======================================
+ Hits 184634 184650 +16
+ Misses 15926 15912 -14
+ Partials 7986 7981 -5
🚀 New features to boost your workflow:
|
avivkeller
approved these changes
Dec 22, 2025
BridgeAR
approved these changes
Dec 22, 2025
Collaborator
Collaborator
|
Landed in 416db75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
eventtarget
Issues and PRs related to the EventTarget implementation.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46323
I see
Eventhas a similar brand check (lib/internal/event_target.js:152) Should we also remove that one?