Skip to content

Conversation

@efekrskl
Copy link
Contributor

Fixes #46323

I see Event has a similar brand check (lib/internal/event_target.js:152) Should we also remove that one?

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 19, 2025
@efekrskl efekrskl force-pushed the fix/remove-eventtarget-custom-inspect-branding branch from 0530cf0 to 830ace5 Compare December 19, 2025 17:50
@efekrskl efekrskl requested a review from BridgeAR December 21, 2025 11:08
@codecov
Copy link

codecov bot commented Dec 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (4f24aff) to head (d8e55f9).
⚠️ Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #61128   +/-   ##
=======================================
  Coverage   88.53%   88.54%           
=======================================
  Files         703      703           
  Lines      208546   208543    -3     
  Branches    40217    40223    +6     
=======================================
+ Hits       184634   184650   +16     
+ Misses      15926    15912   -14     
+ Partials     7986     7981    -5     
Files with missing lines Coverage Δ
lib/internal/event_target.js 99.16% <ø> (-0.01%) ⬇️

... and 52 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller added eventtarget Issues and PRs related to the EventTarget implementation. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 22, 2025
@BridgeAR BridgeAR added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 22, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2025
@nodejs-github-bot
Copy link
Collaborator

@avivkeller avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2025
@nodejs-github-bot nodejs-github-bot merged commit 416db75 into nodejs:main Dec 22, 2025
78 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 416db75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. eventtarget Issues and PRs related to the EventTarget implementation. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error [ERR_INTERNAL_ASSERTION]: TypeError [ERR_INVALID_THIS]: Value of "this" must be of type EventTarget

4 participants