src: remove redundant CHECK #61130
Merged
src: remove redundant CHECK #61130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `SetAuthTag()` returns early (before reaching this line) if `!cipher->IsAuthenticatedMode()`, which expands to the exact same condition that is being `CHECK()`ed here.
tniessen
added
crypto
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61130 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.02%
==========================================
Files 703 703
Lines 208546 208545 -1
Branches 40217 40220 +3
==========================================
- Hits 184634 184599 -35
- Misses 15926 15958 +32
- Partials 7986 7988 +2
🚀 New features to boost your workflow:
|
meixg
approved these changes
Dec 20, 2025
marco-ippolito
approved these changes
Dec 20, 2025
cjihrig
approved these changes
Dec 20, 2025
lpinca
approved these changes
Dec 20, 2025
mertcanaltin
approved these changes
Dec 20, 2025
panva
added
request-ci
panva
approved these changes
Dec 20, 2025
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d7e4108 |
MatricalDefunkt
pushed a commit
to MatricalDefunkt/node
that referenced
this pull request
Dec 22, 2025
The function `SetAuthTag()` returns early (before reaching this line) if `!cipher->IsAuthenticatedMode()`, which expands to the exact same condition that is being `CHECK()`ed here. PR-URL: nodejs#61130 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
SetAuthTag()returns early (before reaching this line) if!cipher->IsAuthenticatedMode(), which expands to the exact same condition that is beingCHECK()ed here.