Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,16 @@ jobs:
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
with:
persist-credentials: false
sparse-checkout: |
/Makefile
/benchmark/
/doc/
/lib/
/src/node_version.h
/tools/
pyproject.toml
*.py
sparse-checkout-cone-mode: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
with:
Expand All @@ -181,6 +191,12 @@ jobs:
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
with:
persist-credentials: false
sparse-checkout: |
/Makefile
/tools/pip/
*.yml
*.yaml
sparse-checkout-cone-mode: false
- name: Use Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
with:
Expand All @@ -200,6 +216,10 @@ jobs:
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
with:
persist-credentials: false
sparse-checkout: |
/tools/lint-sh.mjs
*.sh
sparse-checkout-cone-mode: false
- run: shellcheck -V
- name: Lint Shell scripts
run: tools/lint-sh.mjs .
Expand All @@ -221,6 +241,10 @@ jobs:
with:
fetch-depth: 2
persist-credentials: false
sparse-checkout: |
/tools/lint-pr-url.mjs
/doc/api/
sparse-checkout-cone-mode: false
# GH Actions squashes all PR commits, HEAD^ refers to the base branch.
- run: git diff HEAD^ HEAD -G"pr-url:" -- "*.md" | ./tools/lint-pr-url.mjs ${{ github.event.pull_request.html_url }}
lint-readme:
Expand All @@ -229,6 +253,10 @@ jobs:
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
with:
persist-credentials: false
sparse-checkout: |
README.md
/tools/lint-readme-lists.mjs
sparse-checkout-cone-mode: false
- name: Get team members if possible
if: ${{ (github.event.pull_request && github.event.pull_request.base.ref == github.event.pull_request.base.repo.default_branch) || github.event.ref == github.event.repository.default_branch }}
id: team_members
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/notify-on-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,12 @@ jobs:
with:
persist-credentials: false
- name: Check commit message
id: commit-check
run: npx -q core-validate-commit "$COMMIT"
env:
COMMIT: ${{ github.event.after }}
- name: Slack Notification
if: failure()
if: ${{ failure() && steps.commit-check.conclusion == 'failure' }}
uses: rtCamp/action-slack-notify@e31e87e03dd19038e411e38ae27cbad084a90661 # 2.3.3
env:
SLACK_COLOR: '#DE512A'
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
Edited by MD Faizan
# Node.js

Node.js is an open-source, cross-platform JavaScript runtime environment.
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 14
#define V8_MINOR_VERSION 3
#define V8_BUILD_NUMBER 127
#define V8_PATCH_LEVEL 16
#define V8_PATCH_LEVEL 17

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down
6 changes: 3 additions & 3 deletions deps/v8/src/maglev/arm64/maglev-ir-arm64.cc
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ void Int32Multiply::GenerateCode(MaglevAssembler* masm,
__ Smull(out, left, right);

// Making sure that the 32-bit output is zero-extended.
__ Move(out.W(), out.W());
__ Mov(out.W(), out.W());
}

void Int32MultiplyOverflownBits::SetValueLocationConstraints() {
Expand Down Expand Up @@ -468,7 +468,7 @@ void Int32MultiplyWithOverflow::GenerateCode(MaglevAssembler* masm,

// Making sure that the 32-bit output is zero-extended (and moving it to the
// right register if {out_alias_input} is true).
__ Move(out, res.W());
__ Mov(out, res.W());
}

void Int32DivideWithOverflow::SetValueLocationConstraints() {
Expand Down Expand Up @@ -536,7 +536,7 @@ void Int32DivideWithOverflow::GenerateCode(MaglevAssembler* masm,
__ CompareAndBranch(temp, Immediate(0), ne,
__ GetDeoptLabel(this, DeoptimizeReason::kNotInt32));

__ Move(out, res);
__ Mov(out, res);
}

void Int32ModulusWithOverflow::SetValueLocationConstraints() {
Expand Down
22 changes: 22 additions & 0 deletions deps/v8/test/mjsunit/maglev/regress-466786677.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
// Copyright 2025 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// Flags: --allow-natives-syntax

function trigger(cond) {
let o = {};
let mul = (cond ? 1 : 0x80000000) | 0;
print(mul);
let idx = (mul * 2) | 0;
print(idx);
o[0] = 1.1;
if (cond) o[1] = 2.2;
return o[idx];
}

%PrepareFunctionForOptimization(trigger);
trigger(true);
trigger(false);
%OptimizeMaglevOnNextCall(trigger);
trigger(false);
20 changes: 13 additions & 7 deletions lib/internal/process/task_queues.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ const {

const {
getDefaultTriggerAsyncId,
getHookArrays,
newAsyncId,
initHooksExist,
emitInit,
Expand Down Expand Up @@ -158,13 +159,18 @@ const defaultMicrotaskResourceOpts = { requireManualDestroy: true };
function queueMicrotask(callback) {
validateFunction(callback, 'callback');

const asyncResource = new AsyncResource(
'Microtask',
defaultMicrotaskResourceOpts,
);
asyncResource.callback = callback;

enqueueMicrotask(FunctionPrototypeBind(runMicrotask, asyncResource));
const contextFrame = AsyncContextFrame.current();
if (contextFrame || getHookArrays()[0].length > 0) {
const asyncResource = new AsyncResource(
'Microtask',
defaultMicrotaskResourceOpts,
);
asyncResource.callback = callback;
enqueueMicrotask(FunctionPrototypeBind(runMicrotask, asyncResource));
} else {
// Fast path: no AsyncLocalStorage in use
enqueueMicrotask(callback);
}
}

module.exports = {
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/errors/async_error_nexttick_main.snapshot
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Error: test
at one (*fixtures*async-error.js:4:9)
at two (*fixtures*async-error.js:17:9)
at process.processTicksAndRejections (node:internal*process*task_queues:103:5)
at process.processTicksAndRejections (node:internal*process*task_queues:104:5)
at async three (*fixtures*async-error.js:20:3)
at async four (*fixtures*async-error.js:24:3)
at async main (*async_error_nexttick_main.js:7:5)