Open
Conversation
* Make the intro less C++-centric * Give a GYP-less build example * Remove the duplicate Node-API documentation * Add an ESM example
legendecas
reviewed
Mar 2, 2026
|
|
||
| ```bash | ||
| NODEJS_DEV_ROOT ?= $(shell dirname "$$(command -v node)")/.. | ||
| CXXFLAGS = -std=c++23 -I$(NODEJS_DEV_ROOT)/include/node -fPIC -shared -Wl,-undefined,dynamic_lookup |
Member
There was a problem hiding this comment.
I think the flag -Wl,-undefined,dynamic_lookup only works on macOS, and does not match the above words "On most platforms"...
Contributor
Author
There was a problem hiding this comment.
I tested it from within a docker container with gcc, it didn't seem to cause problems. Happy to update to something else if you have suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nodehas way of knowing what language the shared object was compiled from, C++ is just what we happen to document and support)