Skip to content

Conversation

@avivkeller
Copy link
Member

Description

Add @oramacloud/* to the dependabot config, as we use deps from both @orama/ and @oramacloud/

Validation

N/A

Check List

N/A

Signed-off-by: Aviv Keller <redyetidev@gmail.com>
@avivkeller avivkeller requested a review from Copilot November 20, 2024 13:09
@avivkeller avivkeller requested a review from a team as a code owner November 20, 2024 13:09
@vercel
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nodejs-org ⬜️ Ignored (Inspect) Nov 20, 2024 1:09pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

@avivkeller avivkeller added infrastructure Issues/PRs related to the Repository Infra github_actions:pull-request Trigger Pull Request Checks labels Nov 20, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Nov 20, 2024
@github-actions

This comment was marked as resolved.

@github-actions
Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.73% (627/691) 72.44% (184/254) 94.48% (120/127)

Unit Test Report

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 5.402s ⏱️

@ovflowd
Copy link
Member

ovflowd commented Nov 20, 2024

@redyetidev would you mind making a PR updating the GitHub Workflows so that the Lighthouse doesn't run when Vercel gets skipped?

@ovflowd ovflowd merged commit a895bc0 into main Nov 20, 2024
16 of 17 checks passed
@ovflowd ovflowd deleted the chore/oramacloud/dependabot branch November 20, 2024 19:29
@avivkeller
Copy link
Member Author

@redyetidev would you mind making a PR updating the GitHub Workflows so that the Lighthouse doesn't run when Vercel gets skipped?

Sure thing! I'll make one later today.

@bmuenzenmeyer
Copy link
Contributor

Why are these prs being merged without the 48 hour policy being honored?

@ovflowd
Copy link
Member

ovflowd commented Nov 20, 2024

I used the good judgment/fast track policy but realised I forgot to actually request for fast track... My bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Issues/PRs related to the Repository Infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants