Skip to content

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Dec 20, 2025

For people not working in a culture where people start to go on holidays as early as 20-ish December, it's not exactly clear what "distrupt the holiday season" means and why it matters enough to delay the release. Clarify it instead of requring readers to read between the lines.

Description

Background: I see some misunderstanding on the social media, which AFAICT is not what the original intent of the delay, and TBH personally I would not be able to read between the lines if I read this 8 years ago, before I started working with people that would already be on vacations around 20 December, which seems fairly common in Europe and Americas, since I did not know in this context "holidays" means "Christmas and a bunch of other festivals that we generally don't take time off for" in my country, where people usually are only off on 1 Jan and that's it. If I read it 8 years ago I would interpret it as "the Node.js team is on holidays so can't fix it", which is not how a project mostly built by volunteers actually functions.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

For people not working in a culture where people start to go on
holidays as early as 20-ish December, it's not exactly clear what
"distrupt the holiday season" means and why it matters enough to
delay the release. Clarify it instead of requring readers
to read between the lines.
Copilot AI review requested due to automatic review settings December 20, 2025 11:41
@joyeecheung joyeecheung requested a review from a team as a code owner December 20, 2025 11:41
@vercel
Copy link

vercel bot commented Dec 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Dec 20, 2025 11:44am

@github-actions
Copy link
Contributor

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the clarity of the documentation explaining why the December 2025 security release was delayed to January 7th, 2026. The updated wording makes the rationale more explicit and understandable for international audiences who may not be familiar with Western holiday practices.

  • Replaced vague phrasing about "disrupting the holiday season" with a clear explanation about downstream projects and users being on holiday break
  • Added explicit reasoning about vulnerability disclosure timing and the need for users to be available to evaluate and perform time-sensitive upgrades
  • Made the documentation more culturally inclusive by not assuming readers understand implicit holiday-related context

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.69%. Comparing base (3f57d25) to head (352a896).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8434      +/-   ##
==========================================
+ Coverage   73.64%   73.69%   +0.04%     
==========================================
  Files         107      107              
  Lines        9161     9161              
  Branches      312      311       -1     
==========================================
+ Hits         6747     6751       +4     
+ Misses       2412     2408       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…eleases.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@avivkeller avivkeller added this pull request to the merge queue Dec 20, 2025
Merged via the queue into nodejs:main with commit 9f38df8 Dec 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants