-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: update wording about the security release delay #8434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For people not working in a culture where people start to go on holidays as early as 20-ish December, it's not exactly clear what "distrupt the holiday season" means and why it matters enough to delay the release. Clarify it instead of requring readers to read between the lines.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the clarity of the documentation explaining why the December 2025 security release was delayed to January 7th, 2026. The updated wording makes the rationale more explicit and understandable for international audiences who may not be familiar with Western holiday practices.
- Replaced vague phrasing about "disrupting the holiday season" with a clear explanation about downstream projects and users being on holiday break
- Added explicit reasoning about vulnerability disclosure timing and the need for users to be available to evaluate and perform time-sensitive upgrades
- Made the documentation more culturally inclusive by not assuming readers understand implicit holiday-related context
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
apps/site/pages/en/blog/vulnerability/december-2025-security-releases.md
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8434 +/- ##
==========================================
+ Coverage 73.64% 73.69% +0.04%
==========================================
Files 107 107
Lines 9161 9161
Branches 312 311 -1
==========================================
+ Hits 6747 6751 +4
+ Misses 2412 2408 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
…eleases.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
For people not working in a culture where people start to go on holidays as early as 20-ish December, it's not exactly clear what "distrupt the holiday season" means and why it matters enough to delay the release. Clarify it instead of requring readers to read between the lines.
Description
Background: I see some misunderstanding on the social media, which AFAICT is not what the original intent of the delay, and TBH personally I would not be able to read between the lines if I read this 8 years ago, before I started working with people that would already be on vacations around 20 December, which seems fairly common in Europe and Americas, since I did not know in this context "holidays" means "Christmas and a bunch of other festivals that we generally don't take time off for" in my country, where people usually are only off on 1 Jan and that's it. If I read it 8 years ago I would interpret it as "the Node.js team is on holidays so can't fix it", which is not how a project mostly built by volunteers actually functions.
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.