Skip to content

Feat/dirent path dep0178 #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feat/dirent path dep0178 #248

wants to merge 9 commits into from

Conversation

@brunocroh
Copy link
Member

closes #131

@brunocroh brunocroh requested a review from a team October 21, 2025 23:11
@brunocroh brunocroh mentioned this pull request Oct 22, 2025
Open
19 tasks
AugustinMauroy
AugustinMauroy reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOW bruno that huge !

@AugustinMauroy AugustinMauroy added awaiting author Reviewer has requested something from the author dep:v24 Migration handles deprecation introduced in node v24 dep:EoL Migration handles deprecation introduced in an EoL version of node labels Oct 23, 2025
@brunocroh brunocroh added awaiting reviewer Author has responded and needs action from the reviewer and removed awaiting author Reviewer has requested something from the author labels Oct 25, 2025
@brunocroh brunocroh requested review from a team and AugustinMauroy October 25, 2025 16:37
AugustinMauroy
AugustinMauroy approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! Just few docs thing

recipes/dirent-path-to-parent-path/README.md
This recipe transforms the usage of `dirent.path` to use `dirent.parentPath`.

See [DEP0178](https://nodejs.org/api/deprecations.html#DEP0178).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This codemod handle:
- `node:fs` and `node:fs/promise` import
- `for` loop
- array methods

it's just the idea I'm not good writer

Copy link
Member Author

@brunocroh brunocroh Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I’m not sure if it makes sense to talk about for or array methods here, it might cause more confusion than clarity in the end,

what nodejs docs say about it:
Screenshot 2025-10-28 at 18 33 44

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by "this codemod handle" I mean "which" case is handled

brunocroh and others added 2 commits October 28, 2025 18:32
@brunocroh
fix readme.md title
3d39f27
@brunocroh @AugustinMauroy
Update recipes/dirent-path-to-parent-path/README.md
cfe98ee 
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

awaiting reviewer Author has responded and needs action from the reviewer dep:EoL Migration handles deprecation introduced in an EoL version of node dep:v24 Migration handles deprecation introduced in node v24

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: handle dirent.path depreciation

2 participants

@brunocroh @AugustinMauroy