Skip to content

Fix #175, handle trailing slash on endpoint #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #175, handle trailing slash on endpoint #176

wants to merge 2 commits into from

Conversation

@wes-novack
Copy link

@wes-novack wes-novack commented Jan 5, 2021 •
edited
Loading

No description provided.

@wes-novack @GoFightNguyen
Fix nodevault#175, handle trailing slash on endpoint
e97f19b 
Co-authored-by: Jason Nguyen <jason-nguyen@pluralsight.com>
Co-authored-by: Bret Hubbard <bret-hubbard@pluralsight.com
@codecov
Copy link

codecov bot commented Jan 5, 2021 •
edited
Loading

Codecov Report

Merging #176 (e97f19b) into master (7009726) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          146       147    +1     
  Branches        37        37           
=========================================
+ Hits           146       147    +1
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7009726...e97f19b. Read the comment docs.

@wes-novack
Copy link
Author

Hello @kr1sp1n ! We're not sure why 1 of the checks didn't complete on this PR. Can you provide any context on this?

@MichaelSp MichaelSp mentioned this pull request Apr 24, 2022
Closed
MichaelSp added a commit to vaultaire/vaultaire that referenced this pull request Apr 24, 2022
@MichaelSp @GoFightNguyen
based on nodevault#176
8253a1e 
fixes nodevault#175

Co-authored-by: Jason Nguyen <jason-nguyen@pluralsight.com>
Co-authored-by: Bret Hubbard <bret-hubbard@pluralsight.com
MichaelSp added a commit to vaultaire/vaultaire that referenced this pull request Apr 24, 2022
@MichaelSp @GoFightNguyen
handle trailing slash on endpoint
079bde1 
based on nodevault#176

fixes nodevault#175

Co-authored-by: Jason Nguyen <jason-nguyen@pluralsight.com>
Co-authored-by: Bret Hubbard <bret-hubbard@pluralsight.com
@MichaelSp MichaelSp mentioned this pull request Apr 24, 2022
Merged
@aviadhahami
Copy link
Collaborator

@wes-novack do you mind updating the base branch? (can't do it via the UI here)

@wes-novack
Copy link
Author

I no longer have access to the repo. @GoFightNguyen can you help here?

@codecov-commenter
Copy link

Codecov Report

Merging #176 (e97f19b) into master (18597dd) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e97f19b differs from pull request most recent head 791e322. Consider uploading reports for the commit 791e322 to get more accurate results

@@            Coverage Diff            @@
##            master      #176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          146       147    +1     
  Branches        37        37           
=========================================
+ Hits           146       147    +1
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GoFightNguyen GoFightNguyen mentioned this pull request Nov 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wes-novack @aviadhahami @codecov-commenter @GoFightNguyen