Change normalizing code example in README.md#70
Open
loqimean wants to merge 1 commit intonorman:masterfrom
Open
Change normalizing code example in README.md#70loqimean wants to merge 1 commit intonorman:masterfrom
loqimean wants to merge 1 commit intonorman:masterfrom
Conversation
parndt
requested changes
Mar 1, 2023
Collaborator
parndt
left a comment
parndt
left a comment
There was a problem hiding this comment.
Sorry for the delay in this review..!
|
|
||
| def normalize_friendly_id(input) | ||
| input.to_s.to_slug.normalize(transliterations: :russian).to_s | ||
| input.to_slug.transliterate(:ukrainian).normalize.to_s |
Collaborator
There was a problem hiding this comment.
@loqimean does this handle the situation where input is nil?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Rails 7 and friendly_id v5.4.0, the code example was a little bit not good, 'cause not transliterates slug, but this solution is pretty good