Open
Conversation
Whilst working on the Reproducible Builds effort [0], I noticed that babosa could not be built reproducibly. This is because the __dir__ gets expanded when building/rendering the .gemspec file which is then shipped in the binary package. As this path is dependent on the path in which you build babosa, this makes the build unreproducible. I think that cert_chain is only needed if signing_key is needed, so moving it under the same conditional seems to be safe. The goal, however, is to prevent cert_chain from being included in regular, "normal", builds of the package. I originally filed this in Debian as bug #1041840 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/1041840
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst working on the Reproducible Builds effort I noticed that babosa could not be built reproducibly.
This is because the
__dir__gets expanded when building/rendering the.gemspecfile which is then shipped in the binary package. As this path is dependent on the path in which you build babosa, this makes the build unreproducible.I think that cert_chain is only needed if signing_key is needed, so moving it under the same conditional seems to be safe. The goal, however, is to prevent cert_chain from being included in regular, "normal", builds of the package.
I originally filed this in Debian as bug #1041840.