fix: renamed requirements to dependencies to match Helm standards #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cebidhem <cebidhem@pm.me>
cebidhem
changed the title
Owner
|
You need to resolve conflicts. I also think we may need to wait on this for a v2, as it's a breaking change. But I like the idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cebidhem cebidhem@pm.me
Fixes #88
This PR introduces a breaking change, as it changes the template's key to generate documentation about the sub-charts / dependencies.
Indeed, I assumed it was unnecessary to add a feature flag for this, given the low criticality it can go in a helm-docs v2.
However, I kept the compatibility with Helm v1 and the
requirements.txtfile.All tests have passed.