Collecting breadcrumbs and stacktraces #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CookiesEater
requested changes
Mar 29, 2021
src/SentryTarget.php
Outdated
| [$message, $tags, $exception, $type, $extra] = $this->parseText($text); | ||
|
|
||
| $metadata = []; | ||
| if(!empty($tags)) |
Member
There was a problem hiding this comment.
Thanks for your work!
Please format code according to PSR-12 (spaces and braces)
|
|
||
| \Sentry\captureEvent($event, EventHint::fromArray(array_filter([ | ||
| 'exception' => $data['exception'] ?? null, | ||
| 'extra' => $data['extra'] ?? [], |
Member
There was a problem hiding this comment.
Please check this line, it seems not the same extra data that we can attach to scope
Author
There was a problem hiding this comment.
All scope extra data will be directly copied into extra field of the each event in this method, so both extra arrays has same format
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Requests implements tracking all events with
\Sentry\Breadcrumbto display in Breadcrumbs display.Also implemented collecting
$tracesinto\Sentry\Stacktrace