-
Notifications
You must be signed in to change notification settings - Fork 1
feat: simplify CLI usage with auto page discovery and smart file naming #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…9/cli into feat/simplify-cli-usage
…tion\n\n- Enforce max length in sanitizeFileName with safe fallback\n- Avoid trailing dashes after truncation
… Defer mkdir to per-image write path\n- Skip directory creation if no image is downloaded
|
Moon-DaeSeung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm currently reviewing other tasks, but it's difficult to understand the actual changes here since formatting updates to unrelated files are included. Could you please separate the formatting changes from the main feature or bugfix? This will make the review process much clearer. Thanks!
sure, i’ll wrap this up by tomorrow morning. |
Description of Changes
Here is reference: @notionpresso/notionpresso-react #25
Summary
This PR revolutionizes CLI UX by eliminating manual page URL input and implementing automatic page discovery with
--alloption. Also introduces title-based file naming for better developer experience.File naming structure changed from ID-based to title-based.
abc123def456.jsonmy-blog-post.jsonAction required: Delete existing
notion-data/folder and re-run CLI.What Changed & Why
Problem
Solution
--alloption finds all accessible pages via Search APINOTION_API_KEYfrom.envfileImplementation Details
pages.jsonfor frontend integration.envsupportDocumentation
Review Needed
API reliability concern: Search API may not discover all pages due to Notion limitations. Should we add a fallback method or document this limitation?
Quick Test
Next.js Integration Testing
Review Guide
Reviews are conducted based on priority levels, such as p0, p1, p2, p3, p4, and p5.
p0 ~ p2: If the author decides not to reflect a review for p0 to p2, it signals that a proper discussion with the reviewer is
necessary. It is expected
that the review will be resolved either through incorporating the feedback or through further discussion.
p3: indicates that the reviewer has identified a significant issue, but either lacks a clear solution or the comment lacks sufficient context. Further explanation or additional discussion on the reviewer's concerns is needed.
p4, p5: p4 and p5 suggest low priority, and if the author does not deem them important, these comments can be disregarded.