Conversation
|
A nice-to-have but not a requirement: take a look at this publish script which will sync github releases with publishing to crates.io: https://github.com/novifinancial/opaque-ke/blob/master/.github/workflows/publish.yml Also, in terms of directory structure, any reason why we still need to maintain the plasma-store/ directory instead of just collapsing its contents into the root directory? (i.e. can we get rid of the workspace singleton and just put the src/ folder along side the LICENSE, README.md. etc?) |
|
Thank you! I'll add the publish script. As for directory structure, I'm planning to add another crate for |
|
Hi @irakliyk! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This PR will prepare
plasma-storecrate for publishing to crates.io. I believe the tasks are:Anything else?