Fix coordinate formatting consistency and empty filter state handling#1057
Merged
karilint merged 1 commit intocodex/plan-feature-implementation-for-locality-listfrom Feb 16, 2026
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix unexpected error in Codex-generated pull request
Fix coordinate formatting consistency and empty filter state handling
Feb 16, 2026
6211a5e
into
codex/plan-feature-implementation-for-locality-list
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinate values in CrossSearchTable displayed excessive decimal precision inconsistent with LocalityTable. Empty filter values polluted URL state and server queries.
Changes
Coordinate formatting: Added
formatWithMaxThreeDecimalsformatter todec_latanddec_longcolumns in CrossSearchTable, matching LocalityTable behavior. Handles both numeric and string coordinate values.Filter state sanitization: TableView now excludes empty filter values (empty strings, null, undefined, empty arrays) from URL state and server-side queries via
sanitizeColumnFilters.Test coverage: Added LocalityTable tests verifying coordinate formatting preserves values ≤3 decimals and truncates longer values. CrossSearchTable tests added for parity.
Note:
formatWithMaxThreeDecimalsanddecimalCountare duplicated across both table components - could be extracted to shared utility in follow-up.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.