Fix locality age method persistence and scoped validation#1060
Merged
karilint merged 1 commit intocodex/create-feature-implementation-planfrom Feb 16, 2026
Merged
Fix locality age method persistence and scoped validation#1060karilint merged 1 commit intocodex/create-feature-implementation-planfrom
karilint merged 1 commit intocodex/create-feature-implementation-planfrom
Conversation
Copilot
AI
changed the title
[WIP] Fix unexpected error in generated pull request
Fix locality age method persistence and scoped validation
Feb 16, 2026
689c312
into
codex/create-feature-implementation-plan
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching between dating methods (Time unit, Absolute, Composite) in the Locality Age tab was clearing previously entered age values, forcing users to re-enter data when exploring different dating approaches.
Changes
Age draft persistence: AgeTab now maintains method-specific state (
ageDraftsByMethod) that preservesmin_age,max_age, and basis field selections per dating method. Switching methods saves current values and restores previously entered values for the target method.Scoped validation: Validation logic refactored to evaluate required basis fields only against the active dating method. For composite mode, validation enforces that one row uses time_unit basis while the other uses absolute basis, determined by which fields are populated.
Test coverage: Added regression tests for method round-trip scenarios and fraction-based age recalculation.
Example
Documentation
Updated README.md and CHANGELOG.md with reviewer notes on the persistence behavior and validation scoping.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.