feat(i18n): localise translations for other git providers #1962
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /** | ||
| * Return the text "see on {git provider}" based on the given provider | ||
| */ | ||
| export function useViewOnGitProvider( | ||
| provider: MaybeRefOrGetter<ProviderId | (string & {}) | null | undefined>, | ||
| ) { | ||
| const { t } = useI18n() | ||
| return computed(() => { | ||
| const uProvider = toValue(provider) | ||
| if (!uProvider) { | ||
| return t('common.view_on.git_repo') | ||
| } | ||
| switch (uProvider) { | ||
| case 'github': | ||
| return t('common.view_on.github') | ||
| case 'gitlab': | ||
| return t('common.view_on.gitlab') | ||
| case 'bitbucket': | ||
| return t('common.view_on.bitbucket') | ||
| case 'gitea': | ||
| return t('common.view_on.gitea') | ||
| case 'forgejo': | ||
| return t('common.view_on.forgejo') | ||
| case 'codeberg': | ||
| return t('common.view_on.codeberg') | ||
| case 'sourcehut': | ||
| return t('common.view_on.sourcehut') | ||
| case 'gitee': | ||
| return t('common.view_on.gitee') | ||
| case 'tangled': | ||
| return t('common.view_on.tangled') | ||
| case 'radicle': | ||
| return t('common.view_on.radicle') | ||
| case 'git': | ||
| return t('common.view_on.git_repo') | ||
| } | ||
|
|
||
| if (import.meta.dev) { | ||
| // oxlint-disable-next-line no-console | ||
| console.warn(`missing '${uProvider}' provider, add it to shared/utils/git-providers.ts!`) | ||
| } | ||
| return t('common.view_on.git_repo') | ||
| }) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -178,7 +178,6 @@ | |||||
| "skip_link": "Skip to main content", | ||||||
| "warnings": "Warnings:", | ||||||
| "go_back_home": "Go back home", | ||||||
| "per_week": "/ week", | ||||||
| "vanity_downloads_hint": "Vanity number: no packages displayed | Vanity number: for the displayed package | Vanity number: Sum of {count} displayed packages", | ||||||
| "sort": { | ||||||
|
|
@@ -190,7 +189,21 @@ | |||||
| "cancel": "Cancel", | ||||||
| "save": "Save", | ||||||
| "edit": "Edit", | ||||||
| "error": "Error", | ||||||
| "view_on": { | ||||||
| "npm": "view on npm", | ||||||
|
Contributor
There was a problem hiding this comment. Inconsistent capitalisation: "view" should be "View". All other entries in ✏️ Proposed fix- "npm": "view on npm",
+ "npm": "View on npm",📝 Committable suggestion
Suggested change
Contributor
Author
There was a problem hiding this comment. it's "view" instead of "View" because it was originally like that, the same for github it's "View" because before moving the translation it also was with "View"
Contributor
There was a problem hiding this comment.
✏️ Learnings added
🧠 Learnings used |
||||||
| "github": "View on GitHub", | ||||||
| "gitlab": "View on GitLab", | ||||||
| "bitbucket": "View on Bitbucket", | ||||||
| "codeberg": "View on Codeberg", | ||||||
| "git_repo": "View on Git repository", | ||||||
| "forgejo": "View on Forgejo", | ||||||
| "gitea": "View on Gitea", | ||||||
| "gitee": "View on Gitee", | ||||||
| "radicle": "View on Radicle", | ||||||
| "sourcehut": "View on SourceHut", | ||||||
| "tangled": "View on Tangled" | ||||||
| } | ||||||
| }, | ||||||
| "profile": { | ||||||
| "display_name": "Display Name", | ||||||
|
|
@@ -312,7 +325,6 @@ | |||||
| "readme": { | ||||||
| "title": "Readme", | ||||||
| "no_readme": "No README available.", | ||||||
| "toc_title": "Outline", | ||||||
| "callout": { | ||||||
| "note": "Note", | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have
string & {}, can we usetefromuseI18nto check if the key exists? Otherwise return gihubUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change it to use
tebut I do think it's best to return "Git repository" instead of Github as it is closer to the truth than returninggithubby defaultUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the case to the swtich (without default), then add console.warn (add eslint rule to ignore that console.warn) and return the value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've figured out that the keys can also be referenced in comments, that way 'te' can still be used