NCSDK-35479: Preserve boot request values during reboot #25627

tomchy · 2025-11-17T15:46:09Z

No description provided.

Copilot

Pull Request Overview

This PR implements functionality to preserve bootloader request values across device reboots by introducing a backup mechanism using Zephyr's retention driver.

Updates MCUboot revision to pull/574/head to include the backup functionality
Adds a backup retention area for boot request data in the device tree
Introduces a Kconfig option to enable keeping boot preference values across reboots

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
west.yml	Updates MCUboot revision to pull/574/head for backup support
samples/dfu/ab/sysbuild/nrf54h20dk_nrf54h20_memory_map.dtsi	Adds boot_request_backup retention node and chosen reference
modules/mcuboot/Kconfig	Adds configuration option for preserving boot preferences across reboots

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

modules/mcuboot/Kconfig

NordicBuilder · 2025-11-17T15:46:53Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
mcuboot	nrfconnect/sdk-mcuboot@`19c0a68` (`main`)	nrfconnect/sdk-mcuboot#574	nrfconnect/sdk-mcuboot#574/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

github-actions · 2025-11-17T16:27:01Z

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-25627/nrf/samples/dfu/ab/README.html
https://ncsdoc.z6.web.core.windows.net/PR-25627/nrf/samples/dfu/ab_split/README.html

NordicBuilder · 2025-11-17T20:10:52Z

CI Information

^{To view the history of this post, click the 'edited' button above}
Build number: 16

Inputs:

Sources:

sdk-nrf: PR head: 197dda8aed08e61f0ea4ce58863efbf706a359d0
mcuboot: PR head: 4455d26aeec12718e4e1471ba75ca049f2fb7444

more details

sdk-nrf:

PR head: 197dda8aed08e61f0ea4ce58863efbf706a359d0
merge base: b708336d5f3b9cc9ba91176e97d975c4295e01ba
target head (main): b708336d5f3b9cc9ba91176e97d975c4295e01ba
Diff

mcuboot:

PR head: 4455d26aeec12718e4e1471ba75ca049f2fb7444
merge base: 19c0a68d87a92cca89321d48b03573a20addcc1f
target head (main): 19c0a68d87a92cca89321d48b03573a20addcc1f
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (23)

bootloader
│  ├── mcuboot
│  │  ├── boot
│  │  │  ├── bootutil
│  │  │  │  ├── zephyr
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── src
│  │  │  │  │  │  ├── boot_request.c
│  │  │  │  │  │  ├── boot_request_flash.c
│  │  │  │  │  │  ├── boot_request_mem.h
│  │  │  │  │  │  │ boot_request_retention.c
modules
│  ├── mcuboot
│  │  │ Kconfig
samples
│  ├── dfu
│  │  ├── ab
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── README.rst
│  │  │  ├── boards
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── prj.conf
│  │  │  ├── src
│  │  │  │  │ ab_utils.c
│  │  │  ├── sysbuild.conf
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │  │ prj.conf
│  │  │  │  │ nrf54h20dk_nrf54h20_memory_map.dtsi
│  │  ├── ab_split
│  │  │  ├── README.rst
│  │  │  ├── prj.conf
│  │  │  ├── src
│  │  │  │  │ ab_utils.c
│  │  │  ├── sysbuild
│  │  │  │  ├── mcuboot
│  │  │  │  │  │ prj.conf
│  │  │  │  │ nrf54h20dk_nrf54h20_memory_map.dtsi
│  ├── zephyr
│  │  ├── subsys
│  │  │  ├── mgmt
│  │  │  │  ├── mcumgr
│  │  │  │  │  ├── smp_svr
│  │  │  │  │  │  ├── sysbuild
│  │  │  │  │  │  │  ├── mcuboot_requests.conf
│  │  │  │  │  │  │  │ nrf54h20dk_nrf54h20_memory_map_requests.dtsi
west.yml

Outputs:

Toolchain

Version: df3cc9d822
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:df3cc9d822_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 936
🟡 Integration tests
- ✅ test-fw-nrfconnect-chip
- ❌ test-sdk-find-my
- ✅ test-sdk-mcuboot
- 🟡 test-sdk-dfu

Disabled integration tests

- test-fw-nrfconnect-nrf_lrcs_positioning
- desktop52_verification
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps-main
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread-main
- test-low-level
- test-sdk-audio
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copilot

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

samples/dfu/ab/src/ab_utils.c

Copilot

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

samples/dfu/ab/README.rst

modules/mcuboot/Kconfig

Copilot

Pull Request Overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

samples/dfu/ab_split/src/ab_utils.c

samples/dfu/ab/Kconfig.sysbuild

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

samples/dfu/ab_split/src/ab_utils.c

samples/dfu/ab/src/ab_utils.c

samples/dfu/ab/README.rst

samples/dfu/ab_split/README.rst

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

samples/dfu/ab_split/src/ab_utils.c

samples/dfu/ab/src/ab_utils.c

samples/dfu/ab_split/README.rst

Add a Kconfig option to keep the boot preference between device resets. Ref: NCSDK-35479 Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>

Add additional region to keep the value of boot preference across reboots. Ref: NCSDK-35479 Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

samples/dfu/ab_split/README.rst

samples/dfu/ab_split/src/ab_utils.c

samples/dfu/ab/README.rst

samples/dfu/ab/src/ab_utils.c

Copilot AI review requested due to automatic review settings November 17, 2025 15:46

NordicBuilder added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 17, 2025

Copilot AI reviewed Nov 17, 2025

View reviewed changes

modules/mcuboot/Kconfig Outdated Show resolved Hide resolved

NordicBuilder added manifest-mcuboot DNM labels Nov 17, 2025

tomchy force-pushed the feature/boot_req/NCSDK-35479_Preserve_boot_request_values branch from 68470ac to 74564fc Compare November 17, 2025 15:49

Copilot AI review requested due to automatic review settings November 18, 2025 19:31

tomchy force-pushed the feature/boot_req/NCSDK-35479_Preserve_boot_request_values branch from 74564fc to ac9c492 Compare November 18, 2025 19:31

Copilot AI reviewed Nov 18, 2025

View reviewed changes

samples/dfu/ab/src/ab_utils.c Show resolved Hide resolved

tomchy force-pushed the feature/boot_req/NCSDK-35479_Preserve_boot_request_values branch from ac9c492 to cce173e Compare November 20, 2025 13:08

NordicBuilder added the doc-required PR must not be merged without tech writer approval. label Nov 20, 2025

tomchy marked this pull request as ready for review November 20, 2025 13:17

tomchy requested review from a team as code owners November 20, 2025 13:17

Copilot AI review requested due to automatic review settings November 20, 2025 13:17

tomchy requested review from a team as code owners November 20, 2025 13:17

Copilot AI reviewed Nov 20, 2025

View reviewed changes

samples/dfu/ab/README.rst Outdated Show resolved Hide resolved

modules/mcuboot/Kconfig Outdated Show resolved Hide resolved

tomchy force-pushed the feature/boot_req/NCSDK-35479_Preserve_boot_request_values branch from cce173e to 8bcf729 Compare November 20, 2025 13:32

michalek-no approved these changes Nov 20, 2025

View reviewed changes

robertstypa approved these changes Nov 20, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 20, 2025 15:07

tomchy force-pushed the feature/boot_req/NCSDK-35479_Preserve_boot_request_values branch from 8bcf729 to 2689779 Compare November 20, 2025 15:07

Copilot AI reviewed Nov 20, 2025

View reviewed changes

samples/dfu/ab_split/src/ab_utils.c Show resolved Hide resolved

samples/dfu/ab/Kconfig.sysbuild Show resolved Hide resolved

tomchy force-pushed the feature/boot_req/NCSDK-35479_Preserve_boot_request_values branch from 2689779 to c9535f6 Compare November 21, 2025 12:13

Copilot AI review requested due to automatic review settings November 24, 2025 09:19

tomchy force-pushed the feature/boot_req/NCSDK-35479_Preserve_boot_request_values branch from c9535f6 to b375dd5 Compare November 24, 2025 09:19

Copilot AI reviewed Nov 24, 2025

View reviewed changes

samples/dfu/ab_split/src/ab_utils.c Show resolved Hide resolved

samples/dfu/ab/src/ab_utils.c Show resolved Hide resolved

FrancescoSer requested changes Nov 24, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 24, 2025 11:12

Copilot AI reviewed Nov 24, 2025

View reviewed changes

tomchy force-pushed the feature/boot_req/NCSDK-35479_Preserve_boot_request_values branch from ddbb7ab to 232f481 Compare November 24, 2025 11:14

tomchy requested a review from FrancescoSer November 24, 2025 11:14

FrancescoSer approved these changes Nov 24, 2025

View reviewed changes

tomchy added 4 commits November 25, 2025 09:39

mcuboot: Add a possibility to keep boot preference

81b79dd

Add a Kconfig option to keep the boot preference between device resets. Ref: NCSDK-35479 Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>

ab: Enable boot preference persistance

035f073

Add additional region to keep the value of boot preference across reboots. Ref: NCSDK-35479 Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>

ab_split: Enable boot preference persistance

19ef3f3

Add additional region to keep the value of boot preference across reboots. Ref: NCSDK-35479 Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>

smp_svr: Enable boot preference persistance

197dda8

Add additional region to keep the value of boot preference across reboots. Ref: NCSDK-35479 Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>

Copilot AI review requested due to automatic review settings November 25, 2025 08:39

tomchy force-pushed the feature/boot_req/NCSDK-35479_Preserve_boot_request_values branch from 232f481 to 197dda8 Compare November 25, 2025 08:39

Copilot AI reviewed Nov 25, 2025

View reviewed changes

samples/dfu/ab_split/README.rst Show resolved Hide resolved

samples/dfu/ab_split/src/ab_utils.c Show resolved Hide resolved

samples/dfu/ab/README.rst Show resolved Hide resolved

samples/dfu/ab/src/ab_utils.c Show resolved Hide resolved

NCSDK-35479: Preserve boot request values during reboot #25627

Are you sure you want to change the base?

NCSDK-35479: Preserve boot request values during reboot #25627

Conversation

tomchy commented Nov 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

NordicBuilder commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NordicBuilder commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

NordicBuilder commented Nov 17, 2025 •

edited

Loading

github-actions bot commented Nov 17, 2025 •

edited

Loading

NordicBuilder commented Nov 17, 2025 •

edited

Loading