Skip to content

Add blankCallback for ping, unsubsribe and punsubcribe methods. #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add blankCallback for ping, unsubsribe and punsubcribe methods. #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2a3465
Add blankCallback for ping, unsubsribe and punsubcribe methods.
xzander Dec 10, 2015
8df81f0
Merge remote-tracking branch 'upstream/master'
xzander Jul 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/PubSub/Consumer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public function psubscribe(/* channels */)
*/
public function unsubscribe(/* channels */)
{
$this->writeRequest('unsubscribe', func_get_args());
$this->writeRequest('unsubscribe', func_get_args(), array($this, 'blankCallback'));
}

/**
Expand All @@ -165,7 +165,7 @@ public function unsubscribe(/* channels */)
*/
public function punsubscribe(/* channels */)
{
$this->writeRequest('punsubscribe', func_get_args());
$this->writeRequest('punsubscribe', func_get_args(), array($this, 'blankCallback'));
}

/**
Expand All @@ -176,7 +176,7 @@ public function punsubscribe(/* channels */)
*/
public function ping($payload = null)
{
$this->writeRequest('ping', [$payload]);
$this->writeRequest('ping', [$payload], array($this, 'blankCallback'));
}

/**
Expand All @@ -202,6 +202,15 @@ public function __invoke($payload, $client, $command)
}
}

/**
* Blank callback for ping, unsubscribe and punsubscribe methods
*
* @param string $payload Payload returned by the server.
* @param Client $client Associated client instance.
* @param CommandInterface $command Command instance (always NULL in case of streaming contexts).
*/
public function blankCallback($payload, $client, $command) {}

/**
* Returns the underlying client instance.
*
Expand Down