Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
概要
PR #479 で
instruction_template→instructionへのリネームが行われ、後方互換としてinstruction_templateを受け付ける deprecated コードが残っている。ビルトインピースの
instruction_templateは全てinstructionに置換済み。次のリリースで後方互換コードを削除する。対象箇所
src/infra/config/loaders/pieceParser.ts— movement のinstruction_templateフォールバック + 警告src/infra/config/loaders/pieceParser.ts— loop_monitors judge のinstruction_templateフォールバック + 警告削除タイミング
次のマイナーバージョンリリース時。ユーザーが
.takt/pieces/や~/.takt/pieces/でカスタムピースを使っている場合に影響するため、リリースノートで告知する。Execution Report
Piece
takt-defaultcompleted successfully.Closes #490