Draft
Conversation
Owner
|
挙動を見たほうがよさそうですね! |
Collaborator
Author
|
確かに、そのあたり設計変更が伴いそうなので、一旦本件はペンディングでよさそう。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
別途判断が必要。そもそもBash権限を除去しても問題ないか要検討です。
概要
review-takt-defaultのレビュー専用 movement からBashを除去し、PR レビュー中にシェル実行できないように修正Bashが再び許可されないように固定この対策がない場合の問題
Bashを使って任意コマンドを実行できるrequired_permission_mode未指定のため既定のedit権限が適用され、workspace-write 相当でリポジトリ変更やローカルファイル参照が可能になるnetwork_access: trueの provider 設定と組み合わさると、秘密情報の外部送信や意図しない環境調査の踏み台になる変更内容
builtins/en/pieces/review-takt-default.yamlのgatherと全 reviewer movement からBashを削除builtins/ja/pieces/review-takt-default.yamlに同じ修正を反映src/__tests__/review-takt-default-piece.test.tsを追加し、英日両方でBashが含まれないことを検証テスト
npm test