intake: upstream #1593 (intake/lote-A-pr-1593)#62
intake: upstream #1593 (intake/lote-A-pr-1593)#62nsalvacao wants to merge 1 commit intobaseline/main-sync-2026-02-17from
Conversation
The branch number is computed via command substitution when create-new-feature.sh runs check_existing_branches. In some environments git fetch prints 'Fetching ...' to stdout, which was captured into BRANCH_NUMBER and later caused arithmetic expansion failures like '10#Fetching'. Redirect fetch stdout and stderr to /dev/null inside check_existing_branches so only the numeric value is returned. This keeps behavior unchanged aside from eliminating the noisy-output failure mode. Refs: github#1592
Summary of ChangesHello @nsalvacao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates an upstream fix to prevent a specific error in the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in the create-new-feature.sh script where output from git fetch could be captured into a variable meant to hold only a branch number, leading to a parsing failure. By redirecting both stdout and stderr of the git fetch command to /dev/null, the change ensures that only the intended numeric value is captured. This is a correct and important fix that improves the script's reliability.
|
Closing — Fix already effectively in main This intake PR changes Our No further action needed. Closing. |
Intake PR (Review Phase)
intake/lote-A-pr-1593baseline/main-sync-2026-02-17Policy