Skip to content

intake: upstream #1593 (intake/lote-A-pr-1593)#62

Closed
nsalvacao wants to merge 1 commit intobaseline/main-sync-2026-02-17from
intake/lote-A-pr-1593
Closed

intake: upstream #1593 (intake/lote-A-pr-1593)#62
nsalvacao wants to merge 1 commit intobaseline/main-sync-2026-02-17from
intake/lote-A-pr-1593

Conversation

@nsalvacao
Copy link
Owner

Intake PR (Review Phase)

Policy

  • This PR is for review and validation only.
  • Do not merge until Gemini/Copilot review + local validation are complete.
  • We will follow the 7-step integration workflow.

The branch number is computed via command substitution when create-new-feature.sh runs check_existing_branches. In some environments git fetch prints 'Fetching ...' to stdout, which was captured into BRANCH_NUMBER and later caused arithmetic expansion failures like '10#Fetching'.

Redirect fetch stdout and stderr to /dev/null inside check_existing_branches so only the numeric value is returned. This keeps behavior unchanged aside from eliminating the noisy-output failure mode.

Refs: github#1592
@gemini-code-assist
Copy link

Summary of Changes

Hello @nsalvacao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates an upstream fix to prevent a specific error in the create-new-feature.sh script. The change modifies how git fetch command output is handled, ensuring that standard error is also redirected to /dev/null, which resolves a parsing issue related to branch numbers. This improves the robustness of the script when fetching remote branch information.

Highlights

  • Script Fix: Addressed a potential issue in the create-new-feature.sh script where git fetch output redirection could lead to branch number parsing failures.
Changelog
  • scripts/bash/create-new-feature.sh
    • Modified git fetch command to redirect both standard output and standard error to /dev/null.
Activity
  • No specific activity has been recorded for this pull request yet, as it is in the intake review phase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a bug in the create-new-feature.sh script where output from git fetch could be captured into a variable meant to hold only a branch number, leading to a parsing failure. By redirecting both stdout and stderr of the git fetch command to /dev/null, the change ensures that only the intended numeric value is captured. This is a correct and important fix that improves the script's reliability.

@nsalvacao
Copy link
Owner Author

Closing — Fix already effectively in main

This intake PR changes git fetch --all --prune >/dev/null 2>&1 || true to silence both stdout and stderr on parse failure.

Our main already has git fetch --all --prune 2>/dev/null || true (stderr suppressed) on line 134 of scripts/bash/create-new-feature.sh. The essential fix — gracefully ignoring fetch errors — is already present. The upstream change additionally suppresses stdout (>/dev/null), which is a negligible cosmetic difference.

No further action needed. Closing.

@nsalvacao nsalvacao closed this Feb 19, 2026
@nsalvacao nsalvacao deleted the intake/lote-A-pr-1593 branch February 19, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants