This repository was archived by the owner on Mar 22, 2021. It is now read-only.
fixes test errors due to authenticable/getter_name.rb#265
Open
muZk wants to merge 1 commit intonsarno:masterfrom
Open
fixes test errors due to authenticable/getter_name.rb#265muZk wants to merge 1 commit intonsarno:masterfrom
muZk wants to merge 1 commit intonsarno:masterfrom
Conversation
muZk
changed the title
andrerpbts
approved these changes
Jul 10, 2020
Author
|
When can this be merged? 😮 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#263 causes several (31 of 50) tests to fail due to
NameError: undefined local variable or method current_useror similar.The solution was moving
getter_name.rbfromlib/knock/authenticable/getter_name.rbtolib/knock/getter_name.rb