Skip to content

Fix CI build failures by updating nx.json inputs configuration #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsheaps merged 5 commits into from
Jan 21, 2026
Merged

Fix CI build failures by updating nx.json inputs configuration #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef94238
Fix: Update nx.json inputs configuration to fix CI build failures
openhands-agent May 1, 2025
ec75a72
Address review feedback: Remove namedInputs and affected blocks
openhands-agent May 1, 2025
69d3108
Add missing tsconfig.json files to fix build failures
openhands-agent May 1, 2025
8b16cd9
Fix TypeScript errors in button scripts
openhands-agent May 1, 2025
cfb8311
Fix Element to HTMLElement type casting
openhands-agent May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions nx.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
{
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"affected": {
"defaultBase": "main"
},
"tasksRunnerOptions": {
"default": {
"runner": "nx/tasks-runners/default",
Expand All @@ -21,8 +18,7 @@
"^build"
],
"inputs": [
"production",
"^production"
"{projectRoot}/src/**/*"
],
"outputs": [
"{projectRoot}/dist"
Expand All @@ -31,7 +27,7 @@
},
"lint": {
"inputs": [
"default",
"{projectRoot}/**/*",
"{workspaceRoot}/.oxlintrc.js"
],
"cache": true
Expand Down
11 changes: 7 additions & 4 deletions packages/github-to-graphite-button/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@
const PATH_REGEX = /^\/([^\/]+)\/([^\/]+)\/pull\/([^\/]+).*$/;
const SELECTOR = '[class^="gh-header-actions"]';

const addButton = (toolbar) => {
const [_, org, repo, pr] = window.location.pathname.match(PATH_REGEX);
const addButton = (toolbar: HTMLElement) => {
const match = window.location.pathname.match(PATH_REGEX);
if (!match) return;

const [_, org, repo, pr] = match;
const graphiteLink = `https://app.graphite.dev/github/pr/${org}/${repo}/${pr}/`;

if (document.getElementById("graphiteLink") != null) {
Expand All @@ -35,14 +38,14 @@ const addButton = (toolbar) => {
};

const toolbarObserver = new MutationObserver((_, observer) => {
const toolbar = document.querySelector(SELECTOR);
const toolbar = document.querySelector(SELECTOR) as HTMLElement;
if (toolbar) {
observer.disconnect();
addButton(toolbar);
}
});

let lastPathname;
let lastPathname: string | undefined;
const routeChangeObserver = new MutationObserver(() => {
const { pathname } = window.location;

Expand Down
9 changes: 9 additions & 0 deletions packages/github-to-graphite-button/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"outDir": "./dist",
"rootDir": "./src"
},
"include": ["src/**/*"],
"exclude": ["node_modules", "dist"]
}
11 changes: 7 additions & 4 deletions packages/graphite-to-github-button/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,11 @@ const PATH_REGEX = /^\/github\/pr\/([^\/]+)\/([^\/]+)\/([^\/]+).*$/;
const SELECTOR =
'[class^="PullRequestTitleBar_container_"] > div:nth-child(1) > div:nth-child(2)';

const addButton = (toolbar) => {
const [_, org, repo, pr] = window.location.pathname.match(PATH_REGEX);
const addButton = (toolbar: HTMLElement) => {
const match = window.location.pathname.match(PATH_REGEX);
if (!match) return;

const [_, org, repo, pr] = match;
const gitHubLink = `https://github.com/${org}/${repo}/pull/${pr}`;

if (document.getElementById("gitHubLink") != null) {
Expand All @@ -38,14 +41,14 @@ const addButton = (toolbar) => {
};

const toolbarObserver = new MutationObserver((_, observer) => {
const toolbar = document.querySelector(SELECTOR);
const toolbar = document.querySelector(SELECTOR) as HTMLElement;
if (toolbar) {
observer.disconnect();
addButton(toolbar);
}
});

let lastPathname;
let lastPathname: string | undefined;
const routeChangeObserver = new MutationObserver(() => {
const { pathname } = window.location;

Expand Down
9 changes: 9 additions & 0 deletions packages/graphite-to-github-button/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"outDir": "./dist",
"rootDir": "./src"
},
"include": ["src/**/*"],
"exclude": ["node_modules", "dist"]
}