Skip to content

Conversation

@joseverdezoto
Copy link

No description provided.

@nsheff
Copy link
Owner

nsheff commented Jan 6, 2020

@joseverdezoto this is not passing the travis unit tests, can you look into that?

@joseverdezoto
Copy link
Author

@nsheff could you look over the changes to the loadPEPdb function? I think the previous travis unit tests warnings arose because I didn't have simplecache installed locally. It could also be that warnings were being treated as errors. Let me know if the current changes look good.

@nsheff
Copy link
Owner

nsheff commented Feb 21, 2020

I think the previous travis unit tests warnings arose because I didn't have simplecache installed locally

this was running on travis, right? your local environment would be irrelevant...

@joseverdezoto joseverdezoto requested a review from nsheff February 21, 2020 18:02
@joseverdezoto
Copy link
Author

@nsheff I made the suggested changes tested the function. The only thing I'm not sure of is how we'd include pepr as a dependency. I tried updating the DESCRIPTION file but that commit didn't pass the travis unit tests because pepr could not be installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants