Support structured containers #3670
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3670 +/- ##
==========================================
- Coverage 27.39% 27.25% -0.14%
==========================================
Files 658 660 +2
Lines 41728 41873 +145
==========================================
- Hits 11431 11413 -18
- Misses 29229 29400 +171
+ Partials 1068 1060 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
support-structured-containers
branch
from
3bc4b81 to
5f2da4f
Compare
New version brings structured container and `createV2`, `getInfo` methods in the Container contract. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
If new method is missing, SN falls back to the old ones. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
It's not needed in this case. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
This will make it easier to support nspcc-dev/neofs-contract#534. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Will become available with nspcc-dev/neofs-contract#534 upgrade. If new method is missing, SN falls back to old methods. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
It makes no sense to keep domain as struct field. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Passing explicit parameters is easier to understand. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Will become available with nspcc-dev/neofs-contract#534 upgrade. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
support-structured-containers
branch
from
5f2da4f to
03db265
Compare
Within nspcc-dev/neofs-contract#449, there is a need to store containers as VM structs. Since nspcc-dev/neofs-contract#534, struct items are stored for new containers. This also needs to be done for containers created before the upgrade. Since doing this in a contract update transaction turned out to be too GAS-intensive, this implements structuring through the IR background process. Specialized method is called iteratively doing the same thing, but for several containers at a time. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
support-structured-containers
branch
from
03db265 to
36e3eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.