-
Notifications
You must be signed in to change notification settings - Fork 49
Nickel source implementation, including bug fix and example mac file #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nuPRISM/develop
Are you sure you want to change the base?
Conversation
pdeperio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also add a description to the PR, including any references to documentation, geometry, tests, and analyses you've done with this branch
nickwp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great now. Thanks!
pdeperio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the macros be modularized? i.e. including/calling other mPMT/nuPRISM macros instead of copy/pasting all the parameters? (to minimize the number of macros we need to maintain if some parameter changes.)
|
Sure, I'll do it ASAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the spectrum filename eventually be indicated in the macro NiBall.mac? If so, can you automate the process as much as possible for someone obtaining the file?
For example, storing the file on a password protected Apache server, like on atmpd@sukap004:
/home/atmpd/public_html/pdeperio/test_spectrum.txt
which can be accessed with:
wget --user=atmpd --ask-password https://www-sk.icrr.u-tokyo.ac.jp/~atmpd/pdeperio/test_spectrum.txt
So creating a new sourceme script containing this would work.
If you can use your own different server, would be even better so we don't need to share the above credentials with non-SK collaborators.
|
I am having issues compiling after resolving conflicts due to the following error: Any idea how to solve this? |
|
It's probably an issue due to either:
Which Geant4 version are you using? How do you compile? (cmake compilation should be preferred) |
|
Ok, solved. Thanks! |
Checked commands working with macros/NiBall.mac.
Checked basic distributions of energy, position and hit PMTs distributions here.
The implementation is based on the SK NiCf source simulation (gamma spectrum, geometry and composition) and the Radon implementation by Guillaume (https://github.com/gpronost/WCSim/tree/Radon_v1.8.0_G4.10.03p03).