Skip to content

Conversation

@pabloferm
Copy link

@pabloferm pabloferm commented Apr 23, 2021

Checked commands working with macros/NiBall.mac.
Checked basic distributions of energy, position and hit PMTs distributions here.
The implementation is based on the SK NiCf source simulation (gamma spectrum, geometry and composition) and the Radon implementation by Guillaume (https://github.com/gpronost/WCSim/tree/Radon_v1.8.0_G4.10.03p03).

Copy link

@pdeperio pdeperio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add a description to the PR, including any references to documentation, geometry, tests, and analyses you've done with this branch

@pdeperio pdeperio requested a review from nickwp April 23, 2021 05:08
Copy link

@nickwp nickwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great now. Thanks!

@pdeperio pdeperio self-requested a review May 25, 2021 23:01
Copy link

@pdeperio pdeperio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the macros be modularized? i.e. including/calling other mPMT/nuPRISM macros instead of copy/pasting all the parameters? (to minimize the number of macros we need to maintain if some parameter changes.)

@pabloferm
Copy link
Author

Sure, I'll do it ASAP

Copy link

@pdeperio pdeperio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the spectrum filename eventually be indicated in the macro NiBall.mac? If so, can you automate the process as much as possible for someone obtaining the file?

For example, storing the file on a password protected Apache server, like on atmpd@sukap004:

/home/atmpd/public_html/pdeperio/test_spectrum.txt

which can be accessed with:

wget --user=atmpd --ask-password https://www-sk.icrr.u-tokyo.ac.jp/~atmpd/pdeperio/test_spectrum.txt

So creating a new sourceme script containing this would work.

If you can use your own different server, would be even better so we don't need to share the above credentials with non-SK collaborators.

@pdeperio
Copy link

pdeperio commented Jun 3, 2021

After merging #61, looks like there's some conflicts with radon and injector generators. Please be careful resolving them and consult with @gpronost and @kmtsui if necessary.

@pabloferm
Copy link
Author

I am having issues compiling after resolving conflicts due to the following error:
include/GdNeutronHPCaptureFS.hh:52:40: error: cannot allocate an object of abstract type 'GdNeutronHPCaptureFS'

Any idea how to solve this?

@gpronost
Copy link

It's probably an issue due to either:

  • the Geant4 version you are using
  • the compilator you are using

Which Geant4 version are you using? How do you compile? (cmake compilation should be preferred)

@pabloferm
Copy link
Author

Ok, solved. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants