-
Notifications
You must be signed in to change notification settings - Fork 24
feat: sink integration for pynumaflow-lite #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 93.63% 93.85% +0.21%
==========================================
Files 65 66 +1
Lines 2907 3009 +102
Branches 152 155 +3
==========================================
+ Hits 2722 2824 +102
Misses 135 135
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Signed-off-by: Vigith Maurice <vigith@gmail.com>
| // if not finished, abort it | ||
| if !sig_handle.is_finished() { | ||
| println!("Aborting signal handler"); | ||
| let _ = sig_handle.abort(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method doesn't return anything. The let binding can be removed.
| return responses | ||
|
|
||
|
|
||
| async def start(f: callable): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type annotation looks wrong. Shouldn't it be collections.abc.Callable ?
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Closes #268
Tested in CWS