Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a benchmark for the power function and numerai_corr, running each function 1000 times to measure performance. Additionally, a significant speedup was achieved by optimizing a slow assertion in the power function, and replacing the power function with a more efficient numpy based implementation.
The results of the speedup are:
Master:
Execution time power_bench: 3.6272 seconds
Execution time numerai_corr_bench: 10.5109 seconds
This branch:
Execution time power_bench: 0.7179 seconds
Execution time numerai_corr_bench: 4.9527 seconds
To run the benchmark do:
python -m tests.test_scoring
Additionally, it can be run with --profile argument to do profiling of the functions.