Conversation
commit: |
wattanx
force-pushed
the
chore/revert-eslint
branch
from
7a7ee78 to
c58ec49
Compare
📝 WalkthroughWalkthroughPackage.json dependency updates were applied: eslint was downgraded from version 10.0.2 to 9.39.3, and a new devDependency eslint-scope@9.1.1 was introduced. A corresponding resolution entry was added to pin eslint-scope to version 9.1.1, ensuring consistent package resolution across environments. The changes total 2 additions and 1 removal to the configuration file. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
package.json (1)
29-29: ESLint v9 requires Node.js 18.18.0+, but the declared engine still includes Node 14 and 16.Line 29 pins ESLint v9.39.3, yet Line 62 advertises support for Node 14 and 16. This creates a broken contract—developers using those versions will see linting failures. Either tighten
engines.nodeto>=18.18.0or add a separatedevEnginesfield to clarify the dev tooling requirement.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@package.json` at line 29, The package.json currently pins "eslint": "9.39.3" which requires Node >=18.18.0 while the "engines.node" field still allows Node 14 and 16; update package.json to resolve this mismatch by either tightening the engines.node to ">=18.18.0" (or a compatible range) or add a new field (e.g., "devEngines") documenting that ESLint and other dev tooling require Node >=18.18.0; make the change next to the "eslint" entry and the "engines.node" declaration so the contract is consistent for contributors.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@package.json`:
- Line 29: The package.json currently pins "eslint": "9.39.3" which requires
Node >=18.18.0 while the "engines.node" field still allows Node 14 and 16;
update package.json to resolve this mismatch by either tightening the
engines.node to ">=18.18.0" (or a compatible range) or add a new field (e.g.,
"devEngines") documenting that ESLint and other dev tooling require Node
>=18.18.0; make the change next to the "eslint" entry and the "engines.node"
declaration so the contract is consistent for contributors.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ed09711f-ad07-43be-bc4c-0f3ccca09bad
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
2 participants
🔗 Linked issue
❓ Type of change
📚 Description
Revert eslint from v10 (10.0.2) back to v9 (9.39.3).
neostandard does not fully support ESLint v10 yet.
Even with neostandard 0.13.0, the compatibility is not yet complete — it requires an updated version of
@stylistic/eslint-plugin. However, simply overriding the version of @stylistic/eslint-plugin is not sufficient either, as some rule names have changed.📝 Checklist