fix(google-maps): use noDraw flag in AdvancedMarkerElement clusterer operations#653
fix(google-maps): use noDraw flag in AdvancedMarkerElement clusterer operations#653
Conversation
…operations Without noDraw:true, each addMarker/removeMarker call triggered a full re-clustering cycle. With ~2k markers this caused ~10s load times and console warning spam from clusteringbegin/clusteringend events. Resolves #652
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change modifies Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
Resolves #652
❓ Type of change
📚 Description
ScriptGoogleMapsAdvancedMarkerElementwas callingaddMarker/removeMarkeron the MarkerClusterer without thenoDraw: trueflag, causing a full re-clustering cycle on every single marker addition. With ~2k markers this produced ~4kclusteringbegin/clusteringendevent emissions and ~10s load times. Now usesnoDraw: true+requestRerender()to batch into a single render — matching the existing pattern inScriptGoogleMapsMarker.