fix: handle optional chaining for imports in setupImportMocking function#1433
Merged
fix: handle optional chaining for imports in setupImportMocking function#1433
setupImportMocking function#1433Conversation
commit: |
danielroe
approved these changes
Oct 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
None.
❓ Type of change
📚 Description
Problem
The
setupImportMockingfunction was failing when presets contained string values (e.g.,vitest) instead of objects with animportsproperty.This caused a
TypeErrorwhen trying to accessp.importson string presets, breaking test execution.Solution
Added optional chaining (
?.) to safely check if theimportsproperty exists before calling.includes('setInterval'). This prevents errors when presets are strings rather than objects with an imports array.