WIP: Effect/Itemproperty extending #1056
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnpackEvent - now displays ID, useful to tell linked applied effects. New functions: GetTrueEffect(Count) RemoveEffectById SetEffectImmunityBypass ReplaceEffectByElement
The +5 (or whatever) remains in effect and the material property acts as an or. % based critical/sneak attack immunity. Known issues: When multiple linked damage reduction is restored incorrectly. % based immunities only work if the item property hook is active. To do: Documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The +5 (or whatever) remains in effect and the material property acts as an or.
% based critical/sneak attack immunity.
Plugin choice: Placed in effect as % based critical/sneak attack immunity uses an exclusive hook (though not yet approved).
Damage reduction can go anywhere.
Known issues:
When multiple linked damage reduction is restored incorrectly.
% based immunities only work if the item property hook is active.
To do: Documentation
Things I don't like: forced reservation of an effect ParamInteger, but it at least provides specific-effect material based DR which won't get lost when linking multiple material based damage reductions.