Skip to content

Use callback in future instead of blocking on get #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use callback in future instead of blocking on get #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/main/scala/collaboration.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,12 @@ class CollaborationPlan(drawings: DrawingStore, drawingActor: Actor)
case GET(Path(Seg("drawing" :: id :: Nil))) => {
case Open(s) =>
sockets += id -> (sockets(id) + s)
(drawingActor !! FetchDrawing(id))() match {
case rawSvg: String => s.send(rawSvg)
}
(drawingActor !! FetchDrawing(id)) foreach( x => x match {
//I'm not sure in what thread this callback is executed in,
//so to be safe do the s.send in another thread
case rawSvg: String => scala.actors.Actor.actor { s.send(rawSvg) }
case y => System.err.println("ERROR expected string, got: "+y)
})
case Message(s, Text(msg)) =>
/* Message downstream clients with the new stroke and update
the shared drawing. */
Expand Down