Skip to content

Conversation

@andyvand
Copy link

@andyvand andyvand commented Dec 9, 2019

Xcode 11.0

nygard and others added 30 commits April 2, 2019 12:27
OpenSSL was deprecated in 10.7, and isn't available in 10.11.
Looks like this was left over from #3.
When initializing fixed size structure fields from strings, the number
of bytes copied needs to be the minimum of the structure field and the
string byte count.

Fixes the following class of errors found when running a version of
class-dump build with ASan (Address Sanitizer):

==67822==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6030000095a0 at pc 0x0001068b4d2d bp 0x7fff595270b0 sp 0x7fff59526860
READ of size 16 at 0x6030000095a0 thread T0
    #0 0x1068b4d2c in __asan_memcpy (libclang_rt.asan_osx_dynamic.dylib+0x40d2c)
    #1 0x106716ed4 in -[CDLCSegment initWithDataCursor:] (class-dump+0x100040ed4)
    #2 0x10672d82b in +[CDLoadCommand loadCommandWithDataCursor:] (class-dump+0x10005782b)
    ...
CommonCrypto on OS X 10.11.5 started enforcing limits on the keysize which
are too small, and so this couldn't dump Finder and Dock after that.
This fixes most of the remaining parse errors.
@andyvand andyvand closed this Dec 9, 2019
@andyvand andyvand reopened this Dec 9, 2019
@vampirecat35
Copy link

More updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants