Conversation
AaronDDM
reviewed
Jun 13, 2025
AaronDDM
reviewed
Jun 13, 2025
Collaborator
|
@ajay-k can we update another test to show how it is being used for the actual API call? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
=========================================
Coverage 80.57% 80.57%
Complexity 333 333
=========================================
Files 36 36
Lines 1014 1014
Branches 88 88
=========================================
Hits 817 817
Misses 138 138
Partials 59 59 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Aaron de Mello <314152+AaronDDM@users.noreply.github.com>
Co-authored-by: Aaron de Mello <314152+AaronDDM@users.noreply.github.com>
logo_url and show_nylas_branding options and ability to turn off Nylas branding
Contributor
Author
Yeah, looking into this |
AaronDDM
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for two missing fields (logo_url & showNylasBranding ) in the EmailTemplate class that were documented in the Scheduler API Reference but not implemented in the Java/Kotlin SDK.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.