Handle duplicate NZB segments with fallback#310
Open
arubi9 wants to merge 1 commit intonzbdav-dev:mainfrom
Open
Handle duplicate NZB segments with fallback#310arubi9 wants to merge 1 commit intonzbdav-dev:mainfrom
arubi9 wants to merge 1 commit intonzbdav-dev:mainfrom
Conversation
Author
|
If some can provide feedback on code changes, that would be great. |
Contributor
|
This looks like an unnecessarily large amount of code to solve this issue, so I skipped the review. I think it could be solved much more easily: first, parse the candidates into a map. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Closes #252.