Delegate call to prettier from js-layout to the user #2297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-layout-to-types job should only be the generation of the files. Prettifying the file should be done as a second step, by calling `npm run format .`. This aligns with the UNIX philisophy that a script should be doing only one thing, and well. It removes some dependencies regarding prettier in the stanzas definition, and simplify the addition of new plugins prettier might need.
In the previous patch, we decided to delegate the call to prettier to a second step, called by the user. Therefore, we should stop ignoring the files.
45930
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages. The user is responsible from now to run
npm run format src/bindings/mina-transaction.It also makes the PR #2286 easier to finish. Adding new plugins or updating prettier should not require to update any other script or machinery.
This simplifies also the build process.