[hardfork] updating proof-systems to 0.2.0 and dropping support for setFeeWithSnarkCost #2657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleepbloopsify
commented
Dec 2, 2025
Comment on lines
-563
to
-566
| setFeePerSnarkCost(newFeePerSnarkCost: number) { | ||
| let { totalTimeRequired } = getTotalTimeRequired(transaction.accountUpdates); | ||
| return this.setFee(new UInt64(Math.round(totalTimeRequired * newFeePerSnarkCost))); | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
@Trivo25 Is it alright if I completely drop this function?
I'm afraid some people might be using it, but because we drop the concept of "snark cost" in the hard fork, supporting this is pretty impossible without it becoming a no-op.
I'd prefer for this to be a breaking change over a non-breaking one (maybe this is where changelog would be appropriate)
Contributor
Author
|
This also fixes: o1-labs/mina-rust#1676 |
bleepbloopsify
force-pushed
the
leon/develop-3.0/must-work
branch
from
3d1a790 to
4e402f7
Compare
bleepbloopsify
force-pushed
the
leon/develop-3.0/must-work
branch
from
b47a1fa to
3808513
Compare
Contributor
Author
|
CI is broken because this PR is missing from We reconfigured proof-systems to work properly, but now we aren't building it properly in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title, this branch is temporary and meant to demonstrate the minimal subset of changes that need to happen to get a green build on o1js with mesa.
We're using:
mina#mesaand
proof-systems#0.2.0With a custom branch splicing the two together.