(native prover) verifier index #3360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2025
querolita
approved these changes
Nov 3, 2025
Member
querolita
left a comment
querolita
left a comment
There was a problem hiding this comment.
Requires we shift (no pun intended) to a uniform format for some duplicate types, but that's okay 👍🏻
|
|
||
| #[napi(object)] | ||
| #[derive(Clone, Debug, Serialize, Deserialize, Default)] | ||
| pub struct WasmLookupPatterns { |
Member
There was a problem hiding this comment.
these types or a very very similar struct should be in plonk-napi/src/wrappers/lookups.rs
|
|
||
| #[napi(object)] | ||
| #[derive(Clone, Debug, Serialize, Deserialize, Default)] | ||
| pub struct WasmFqPolyComm { |
Member
There was a problem hiding this comment.
There was a definition of polynomial commitments in plonk-napi/src/poly_comm.rs but using
pub unshifted: WasmVector<$WasmG>,
pub shifted: Option<$WasmG>,instead, I am fine with using a simpler type for vectors given that we are using napi
Member
There was a problem hiding this comment.
We should follow a uniform format when we merge the workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
o1-labs/o1js#2609
#3360
MinaProtocol/mina#18038