[Draft] Update from QT5.15 to QT6.9#285
Closed
guillaume-haerinck wants to merge 1 commit intoo3de:mainfrom
Closed
Conversation
Signed-off-by: guillaume-haerinck <guillaume.haerinck@outlook.com>
Contributor
Author
|
So I pushed a bit the testing and going directly to 6.9 is too much of a gap due to the fact that O3DE is accessing private QT5 headers in many places. I started to fix the O3DE build when targetting Qt 6.0.0 which would be a great in-between step. See o3de/o3de#19122 |
|
If going to 6.0 is easier transition and then to a higher is the plan then perhaps we should go to 6.8 instead of 6.9 because 6.8 is an LTS, 6.9 is not. But if 6.9 has something we absolutely want then I think we could justify it. |
Contributor
Author
|
Closed in favor of #293 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to :
Upgrade the QT library version to QT6.9 while keeping changes made by O3DE when it makes sense
- New ManualStyleSheet flag
- Styling rendering optimization
- Advanced layouting for tooltips
- MacOS ssl changes
- Tree view expand behavior changes
What remains ?
It seems that the resource files are not built into the right folders with the
qt_add_resourcescommand. You can play around by changing things in.o3de\3rdParty\packages\qt-6.9.1-rev1-windowsfor a faster iteration time than regenerating this package. The resource compilation is also handled incmake/LYWrappers.cmakewhen looping for AUTORCC itemsFork of QT : The only notable changes are in QBase module and these would need to be properly tested one by one to know if we decide to keep the change or go with vanilla QT.
O3DE : The target branch for QT6 contains many changes but some remains to be tested. Code that is dodgy or commented out for now can be found by looking for
// #QT6_TODOQT Targets : I am currently omitting QtTools module from the build as it builds way more than we need and has issues (we only need it for translation support). We would also need to build QT against our version of Tiff and OpenSSL, but I had issues doing so. This will need to be looked at.
Platform : This is only for Windows for now, linux and mac will have to be looked at in parrallel or right after. In particular for linux we will want to build the QWayland module
How to test ?
Prerequisites are a valid python3 install, ninja, msvc and cmake
python .\build_package.py --search_path ..\..\3p-package-source qt-6.9.1-rev1-windowsqt-6.9.1-rev1-windows.tar.xzlocated in this repo underpackagesC:\Users\YOUR_USER_NAME\.o3de\3rdParty\downloaded_packages