Open
Conversation
Author
|
The tests fail due to ancient Clang and GCC hardcoded in the GHA workflows: I can revert |
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
890e0ad to
99dfde3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR bumps libsdformat from 13.5.0 to 16.0.1
arm64v8/ubuntu:22.04is invalid, as official Ubuntu images are multi-arch underubuntu)Note:
libsdformatXX.so(e.g.,libsdformat13.so) is not a valid target anymore (as of 16.0.1), the target is renamed to match libsdformat conventionA small typo in README was fixed additionally.
Tested
The binaries were built locally:
cd 3p-package-source/Scripts/extras python3 ./pull_and_build_from_git.py ../../package-system/sdformat --platform-name Linux --clean python3 ./pull_and_build_from_git.py ../../package-system/sdformat --platform-name Linux-aarch64 --cleanexported with scripts from https://github.com/o3de/3p-package-scripts, in particular:
cd 3p-package-scripts/o3de_package_scripts python3 pack_package.py -o ../../3p-package-source/package-system/sdformat/temp/out --search_path ../../3p-package-source/package-system/sdformat ../../3p-package-source/package-system/sdformat/temp/sdformat-linux-aarch64 python3 pack_package.py -o ../../3p-package-source/package-system/sdformat/temp/out --search_path ../../3p-package-source/package-system/sdformat ../../3p-package-source/package-system/sdformat/temp/sdformat-linux-aarch64the first one was also untared into
~/.o3de/3rdParty/packages/sdformat-16.0.1-rev1-linuxand tested against RobotImporter in O3DE extras: o3de/o3de-extras#1024