New AutomatedNightlyTestSuite for ASV AR.#620
Draft
jromnoa wants to merge 2 commits intoo3de:developmentfrom
Draft
New AutomatedNightlyTestSuite for ASV AR.#620jromnoa wants to merge 2 commits intoo3de:developmentfrom
jromnoa wants to merge 2 commits intoo3de:developmentfrom
Conversation
…ed for selecting the tests to run in the main GPU test runs for AtomSampleViewerStandalone. It also fixes some small import errors and identifies the AtomSampleViewer project by its correct o3de-atom-sampleviewer project name instead. Signed-off-by: NULL <jromnoa@amazon.com>
jromnoa
added
sig/graphics-audio
priority/major
rgba16f
approved these changes
Apr 12, 2023
smurly
reviewed
Apr 12, 2023
Contributor
smurly
left a comment
smurly
left a comment
There was a problem hiding this comment.
not seeing _AutomatedNightlyTestSuite_.bv.lua in the PR
Signed-off-by: NULL <jromnoa@amazon.com>
smurly
approved these changes
Apr 12, 2023
NeilGitGud
approved these changes
Apr 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
_AutomatedNightlyTestSuite_.bv.luatest file which targets specific reliable tests for use with ASV AR.ShaderReloadSoakTestto the_FullTestSuite_.bv.luatest file as requested in the original internal JIRA request (can't link here). The intent is thatShaderReloadSoakTestandMaterialHotReloadTestare not part of this new_AutomatedNightlyTestSuite_.bv.luatest file but remain as part of the_FullTestSuite_.bv.luatest file.Some important notes about this PR:
AtomSampleViewerStandalone.exewithAtomSampleViewer.GameLauncher.exeand it mostly worked, other than the CLI args. So, in theory, this code should run as expected once the issue with the AtomSampleViewerStandalone target is resolved.