Refactor storage module into separate files by operation#283
Open
wbssbw wants to merge 4 commits intoobelisk:mainfrom
Open
Refactor storage module into separate files by operation#283wbssbw wants to merge 4 commits intoobelisk:mainfrom
wbssbw wants to merge 4 commits intoobelisk:mainfrom
Conversation
obelisk
requested changes
Mar 13, 2026
Owner
obelisk
left a comment
obelisk
left a comment
There was a problem hiding this comment.
Also interested in any feedback from @michelemin as he was one of the most recent people to touch this code
Comment on lines
+116
to
+127
| match insert_common( | ||
| env_data, | ||
| storage, | ||
| namespace, | ||
| key, | ||
| value, | ||
| memory_view, | ||
| data_buffer, | ||
| data_buffer_len, | ||
| db.config.size_limit.clone(), | ||
| db.used_storage.clone(), | ||
| ) { |
Owner
There was a problem hiding this comment.
This is a tonne of parameters. Do you think there is a way we can make this more clear?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructures the
storage.rsfile into a modular package with separate files for each storage operation (get, insert, delete, list). This improves code organization, readability, and maintainability while preserving all existing functionality.Changes
Code structure:
runtime/plaid/src/functions/storage.rswith astorage/directory containing:mod.rs- Module exports and shared macrosget.rs-getandget_sharedoperationsinsert.rs-insertandinsert_sharedoperationsdelete.rs-deleteanddelete_sharedoperationslist.rs-list_keysandlist_keys_sharedoperationsinsert.rs:fetch_existing_data_size- Retrieves current key-value sizecheck_storage_limit- Validates storage quota before insertionhandle_insertion_result- Standardizes result processing